Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make attrs public #187

Merged
merged 1 commit into from
Nov 25, 2022
Merged

make attrs public #187

merged 1 commit into from
Nov 25, 2022

Conversation

hwchase17
Copy link
Contributor

since they are used outside of the class, should be public

@hwchase17 hwchase17 merged commit b913df3 into master Nov 25, 2022
@hwchase17 hwchase17 deleted the harrison/make_public branch November 25, 2022 04:11
@moyueheng moyueheng mentioned this pull request Oct 6, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hwchase17