Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Add solar model chat model #18556

Merged
merged 11 commits into from
Mar 28, 2024
Merged

Conversation

Tokkiu
Copy link
Contributor

@Tokkiu Tokkiu commented Mar 5, 2024

Add our solar chat models, available model choices:

  • solar-1-mini-chat
  • solar-1-mini-translate-enko
  • solar-1-mini-translate-koen

More documents and pricing can be found at https://console.upstage.ai/services/solar.

The references to our solar model can be found at

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 5, 2024
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain 🛑 Canceled (Inspect) Mar 28, 2024 6:54am

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Mar 5, 2024
libs/community/langchain_community/chat_models/solar.py Outdated Show resolved Hide resolved
libs/community/langchain_community/chat_models/solar.py Outdated Show resolved Hide resolved
libs/community/langchain_community/llms/solar.py Outdated Show resolved Hide resolved
temperature = 0.3

class Config:
allow_population_by_field_name = True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for? any comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a config for pydantic object. The detailed explanation lies here. https://docs.pydantic.dev/1.10/usage/model_config. In this pr, we just follow the common sense in this repo such as openai implementation.

allow_population_by_field_name = True

return values

@root_validator()
def validate_environment(cls, values: Dict) -> Dict:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed this function would raise an exception if it detected any issues in its environment. Did I overlook something?

Example:
.. code-block:: python
from langchain_community.chat_models.solar import SolarChat
solar = SolarChat(model="solar-v1-8k")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use SolarLLM for greater generality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could support normal api calls, I believe we could let users touch any model within our solar system.

Copy link

@jaeholee2212 jaeholee2212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the pr. Let's just ship it.

@efriis efriis self-assigned this Mar 11, 2024
@Tokkiu
Copy link
Contributor Author

Tokkiu commented Mar 17, 2024

@efriis Just found the vercel deployment is failed. Do you have any suggestion?

Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! The current integration is failing some of our standard lint checks. Here's the guide on running and fixing them! https://python.langchain.com/docs/contributing/code

I can get around to fixing some of them this week if it's difficult to set up.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 28, 2024
@baskaryan baskaryan enabled auto-merge (squash) March 28, 2024 06:46
@Tokkiu
Copy link
Contributor Author

Tokkiu commented Mar 28, 2024

@efriis @baskaryan Thanks for your help again. The pr is blocked by this message:
'Vercel — Canceled by a more recent commit in the same branch'.
Is there any solution to this one?

@baskaryan baskaryan disabled auto-merge March 28, 2024 19:31
@baskaryan baskaryan merged commit 75173d3 into langchain-ai:master Mar 28, 2024
59 of 60 checks passed
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
Add our solar chat models, available model choices:
* solar-1-mini-chat
* solar-1-mini-translate-enko
* solar-1-mini-translate-koen

More documents and pricing can be found at
https://console.upstage.ai/services/solar.

The references to our solar model can be found at
* https://arxiv.org/abs/2402.17032

---------

Co-authored-by: Bagatur <[email protected]>
Co-authored-by: Bagatur <[email protected]>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
Add our solar chat models, available model choices:
* solar-1-mini-chat
* solar-1-mini-translate-enko
* solar-1-mini-translate-koen

More documents and pricing can be found at
https://console.upstage.ai/services/solar.

The references to our solar model can be found at
* https://arxiv.org/abs/2402.17032

---------

Co-authored-by: Bagatur <[email protected]>
Co-authored-by: Bagatur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: models Related to LLMs or chat model modules size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants