community: better support of pathlib paths in document loaders #18396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mmajewsk
changed the title
mmajewsk
changed the title
dosubot
bot
added
size:L
|
Looks good for scanning quickl |
|
@eyurtsev i think this may be ready to merge now |
|
@efriis I think this is ready to merge |
|
I'm trying to mention someone else: @baskaryan can you merge this? |
|
@eyurtsev so far i'm upkeeping with the changes in master, it would be nice to it merged |
|
I'll try to merge tomorrow added myself as reviewer |
|
tomorrow is relative i guess |
|
sorry for the delay @mmajewsk and thanks for the contribution! |
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…hain-ai#18396) So this arose from the langchain-ai#18397 problem of document loaders not supporting `pathlib.Path`. This pull request provides more uniform support for Path as an argument. The core ideas for this upgrade: - if there is a local file path used as an argument, it should be supported as `pathlib.Path` - if there are some external calls that may or may not support Pathlib, the argument is immidiately converted to `str` - if there `self.file_path` is used in a way that it allows for it to stay pathlib without conversion, is is only converted for the metadata. Twitter handle: https://twitter.com/mwmajewsk
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
So this arose from the #18397 problem of document loaders not supporting `pathlib.Path`. This pull request provides more uniform support for Path as an argument. The core ideas for this upgrade: - if there is a local file path used as an argument, it should be supported as `pathlib.Path` - if there are some external calls that may or may not support Pathlib, the argument is immidiately converted to `str` - if there `self.file_path` is used in a way that it allows for it to stay pathlib without conversion, is is only converted for the metadata. Twitter handle: https://twitter.com/mwmajewsk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this arose from the #18397 problem of document loaders not supporting
pathlib.Path.This pull request provides more uniform support for Path as an argument.
The core ideas for this upgrade:
pathlib.Pathstrself.file_pathis used in a way that it allows for it to stay pathlib without conversion, is is only converted for the metadata.Twitter handle: https://twitter.com/mwmajewsk