Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Langchain/New-feature: Added Haskell support in langchain.text_splitter module #16191

Merged
merged 11 commits into from
Mar 29, 2024
Merged

Langchain/New-feature: Added Haskell support in langchain.text_splitter module #16191

merged 11 commits into from
Mar 29, 2024

Conversation

Nisarg1112
Copy link
Contributor

  • Description: Haskell language support added in text_splitter module
  • Dependencies: No
  • Twitter handle: @nisargtr

If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 18, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 8:17pm

@dosubot dosubot bot added Ɑ: agent Related to agents module 🤖:improvement Medium size change to existing code to handle new use-cases 🔌: redis Primarily related to Redis integrations labels Jan 18, 2024
@Nisarg1112 Nisarg1112 mentioned this pull request Jan 18, 2024
Merged
fynnfluegge pushed a commit to fynnfluegge/codeqai that referenced this pull request Jan 18, 2024
@Nisarg1112
feat: Haskell support added, Bugs fixed in the case of Azure_OpenAI (#28
f6f3907 
)

1. In the case of Azure_OpenAI - Some bugs are fixed
2. Added support of Haskell language
3. Added support of Haskell language in text_splitter module of
Langchain. PR for the same -
langchain-ai/langchain#16191
baskaryan
baskaryan approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's some merge conflicts, but code lgtm! thank you @Nisarg1112!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 22, 2024
@baskaryan
Copy link
Collaborator

if you have a chance would be great to add an example to docs/docs/modules/data_connection/document_transformers/code_splitter.ipynb page

@baskaryan baskaryan added needs documentation PR needs to be updated with documentation and removed 🔌: redis Primarily related to Redis integrations Ɑ: agent Related to agents module labels Jan 22, 2024
@Nisarg1112
Copy link
Contributor Author

if you have a chance would be great to add an example to docs/docs/modules/data_connection/document_transformers/code_splitter.ipynb page

Sure, will add.

@fynnfluegge
Copy link
Contributor

Hey @Nisarg1112, if you sync your master branch with latest langchain master branch I can add the examples to code_splitter.ipynb

@hwchase17 hwchase17 closed this Jan 30, 2024
@Nisarg1112
Copy link
Contributor Author

@hwchase17 Hi, I was planning to sync this branch with the latest master. I noticed the pull request has been closed. Could you please share the reason behind the decision? Thank you for your time.

@baskaryan
Copy link
Collaborator

not intentional, we can't reopen at the moment but will do so as soon as we can :/ See #16796

@baskaryan baskaryan reopened this Jan 30, 2024
@fynnfluegge
Copy link
Contributor

@baskaryan thank you 🙏

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 3, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 3, 2024
@Nisarg1112
Copy link
Contributor Author

@baskaryan Aplogies for the delay! I got stuck at work.

I've resolved conflicts and also added examples to the code_splitter notebook.
Can you please review these changes?

@fynnfluegge - Never mind - I've added example. Thanks!

@Nisarg1112
Copy link
Contributor Author

@baskaryan Hey, Just a gentle ping on this. Is there any issue with this PR that needs to be addressed before merging it?

@Nisarg1112
Copy link
Contributor Author

@baskaryan Hey, are we planning to merge this PR? We wanted to merge this PR to main branch for future purposes related to Haskell language.

@baskaryan baskaryan enabled auto-merge (squash) March 29, 2024 20:03
@baskaryan baskaryan merged commit 1252ccc into langchain-ai:master Mar 29, 2024
80 checks passed
@Nisarg1112
Copy link
Contributor Author

@baskaryan Thanks for your support!

gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@Nisarg1112 @baskaryan @gkorland
text-splitters[minor]: Added Haskell support in langchain.text_splitt…
206cb88 
…er module (langchain-ai#16191)

- **Description:** Haskell language support added in text_splitter
module
  - **Dependencies:** No
  - **Twitter handle:** @nisargtr

If no one reviews your PR within a few days, please @-mention one of
@baskaryan, @eyurtsev, @hwchase17.

---------

Co-authored-by: Bagatur <[email protected]>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@Nisarg1112 @baskaryan @hinthornw
text-splitters[minor]: Added Haskell support in langchain.text_splitt…
66835b6 
…er module (#16191)

- **Description:** Haskell language support added in text_splitter
module
  - **Dependencies:** No
  - **Twitter handle:** @nisargtr

If no one reviews your PR within a few days, please @-mention one of
@baskaryan, @eyurtsev, @hwchase17.

---------

Co-authored-by: Bagatur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan approved these changes

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. needs documentation PR needs to be updated with documentation size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nisarg1112 @baskaryan @fynnfluegge @hwchase17