Quote tool names #11463
Closed
Quote tool names #11463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: agent
hwchase17
reviewed
Oct 10, 2023
|
Most open source LLMs does not work without this PR. How worse it could be if we merge this PR? |
|
Apologies for the slow review! Pr has some merge conflicts, happy to re-review if you'd like to resolve |
|
closing due to inactivity and merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{llm_output}") #1477 ValueError: Could not parse LLM output: #1358The original prompt template is ambiguous because it does not tell whether the tool names should be quoted or not. This PR makes it clear that the tool names should be quoted. It fixes #1358 for Nous-Hermes-Llama2-13b according to my tests.