Sagemaker endpoint capability to inject boto3 client for cross account scenarios #10728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vikramshitole
commented
Sep 18, 2023
vikramshitole
commented
- **Description: Allow to inject boto3 client for Cross account access type of scenarios in using Sagemaker Endpoint **
- Issue:Sagemaker Endpoint cross account capability #10634 Issue: How to configure Amazon SageMaker endpoint #10184
- Dependencies: None
- Tag maintainer:
- Twitter handle:lethargicoder
…account scenarios
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
|
lgtm, thanks @vikramshitole! |
baskaryan
added
the
lgtm
|
I think the sagemaker_endpoint under embedding also need this fix: https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/embeddings/sagemaker_endpoint.py#L50 |
|
@gretchency raised PR for same #12106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.