Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sqlite-vss as a vectorstore option #1019

Closed
nfcampos opened this issue Feb 13, 2023 · 5 comments
Closed

Add sqlite-vss as a vectorstore option #1019

nfcampos opened this issue Feb 13, 2023 · 5 comments

Comments

@nfcampos
Copy link
Collaborator

https://github.com/asg017/sqlite-vss

I think this is an interesting option, FAISS indices backed with SQLite storage and interface, could be the easiest step up from in memory FAISS to something persisted before going for a hosted vector store
@philippe2803
Copy link
Contributor

Working on it

@philippe2803 philippe2803 mentioned this issue Aug 31, 2023
Merged
baskaryan pushed a commit that referenced this issue Sep 1, 2023
@philippe2803
Add sqlite-vss as a vector database (#10047)
3dafbd8 
This adds sqlite-vss as an option for a vector database. Contains the
code and a few tests. Tests are passing and the library sqlite-vss is
added as optional as explained in the contributing guidelines. I
adjusted the code for lint/black/ and mypy. It looks that everything is
currently passing.

Adding sqlite-vss was mentioned in this issue:
#1019.
Also mentioned here in the sqlite-vss repo for the curious:
asg017/sqlite-vss#66

Maintainer tag: @baskaryan

---------

Co-authored-by: Philippe Oger <[email protected]>
@abdul-hamid-achik
Copy link

this one seems to be done already guys #10047

btw big thanks for adding this 💯

@dosubot DosuBot
Copy link

dosubot bot commented Dec 14, 2023

Hi, @nfcampos,

I'm helping the LangChain team manage their backlog and am marking this issue as stale. The issue you opened suggested adding sqlite-vss as a vectorstore option to facilitate the transition from in-memory FAISS to a persisted storage solution. There have been comments from philippe2803 indicating that work is in progress, and abdul-hamid-achik has pointed out a related pull request that seems to address this issue.

Could you please confirm if this issue is still relevant to the latest version of the LangChain repository? If it is, please let the LangChain team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days. Thank you!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 14, 2023
@philippe2803
Copy link
Contributor

This issue should be marked as resolved. The PR has been merged and we now have sqlite-vss as an option for vector store.

@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 15, 2023
@dosubot DosuBot
Copy link

dosubot bot commented Dec 15, 2023

Thank you for the update, @philippe2803! We appreciate your contribution and are glad to hear that the PR has been merged to address this issue. We will proceed to close the issue accordingly.

@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nfcampos @philippe2803 @abdul-hamid-achik