Fixing multi-part response parsing #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alx13
force-pushed
the
alx13/multi-part-response
branch
from
ddd7585
to
40237b2
Compare
lkuligin
reviewed
Apr 18, 2024
|
|
||
| for part in response_candidate.content.parts: | ||
| try: | ||
| text = part.text |
There was a problem hiding this comment.
nits: maybe if hasattr(part, "text") and part.text: ... instead
There was a problem hiding this comment.
This is a @property getter, it would not work
lkuligin
reviewed
Apr 18, 2024
alx13
force-pushed
the
alx13/multi-part-response
branch
2 times, most recently
from
6f88213
to
e288305
Compare
alx13
force-pushed
the
alx13/multi-part-response
branch
from
e288305
to
e66b89b
Compare
alx13
force-pushed
the
alx13/multi-part-response
branch
7 times, most recently
from
74c7af5
to
62e98af
Compare
alx13
force-pushed
the
alx13/multi-part-response
branch
from
62e98af
to
5ed6397
Compare
lkuligin
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.