added image loader with Cloud Vision API #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holtskinner
requested changes
Apr 1, 2024
| client_options = None | ||
| print(project) | ||
| if project: | ||
| client_options = {"quota_project_id": project} |
There was a problem hiding this comment.
Can you change this to use the ClientOptions class from google.api_core.client_options?
There was a problem hiding this comment.
why? the client expect ClientOptions or a dict.
|
|
||
|
|
||
| class CloudImageLoader(BaseBlobParser): | ||
| def __init__(self, project: Optional[str] = None): |
There was a problem hiding this comment.
For consistency with other connectors, can this variable be project_id
There was a problem hiding this comment.
actually, for LLM/ChatModels we use project, so I'd rather stick to project and eventually change everything else to follow the most frequently used integration, wdyt?
holtskinner
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.