Skip to content

Commit

Permalink
Add support for Ruby 3.4
Browse files Browse the repository at this point in the history
  • Loading branch information
christopher-b committed Jan 9, 2025
1 parent aa7c3b5 commit dff06bd
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 8 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})

* Added support for Ruby 3.4

## v1.4.3 - [December 6, 2024](https://github.com/lando/ruby/releases/tag/v1.4.3)

* Updated the version index.md to get Docuverse page to build correctly.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Add a `ruby` service to your Landofile
```yaml
services:
myservice:
type: ruby:3.3
type: ruby:3.4
```
For more info you should check out the [docs](https://docs.lando.dev/ruby):
Expand Down
2 changes: 1 addition & 1 deletion builders/ruby.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = {
name: 'ruby',
config: {
version: '2.7',
supported: ['3.3', '3.2', '3.1', '3.0', '2.7', '2.6', '2.5', '2.4', '2.3', '1.9'],
supported: ['3.4', '3.3', '3.2', '3.1', '3.0', '2.7', '2.6', '2.5', '2.4', '2.3', '1.9'],
patchesSupported: true,
command: 'tail -f /dev/null',
legacy: ['3.0', '2.6', '2.5', '2.4', '2.3', '1.9'],
Expand Down
2 changes: 1 addition & 1 deletion docs/config.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Also note that the options, in addition to the [build steps](https://docs.lando.
```yaml
services:
myservice:
type: ruby:3.3
type: ruby:3.4
port: 80
command: tail -f /dev/null
```
Expand Down
3 changes: 2 additions & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ You can easily add it to your Lando app by adding an entry to the [services](htt

## Supported versions

* [3.4](https://hub.docker.com/_/ruby)
* [3.3](https://hub.docker.com/_/ruby)
* [3.2](https://hub.docker.com/_/ruby)
* [3.1](https://hub.docker.com/_/ruby)
Expand Down Expand Up @@ -42,7 +43,7 @@ To use a patch version, you can do something as shown below:
```yaml
services:
myservice:
type: ruby:3.3.5
type: ruby:3.4.1
```
But make sure you use one of the available [patch tags](https://hub.docker.com/_/ruby/tags) for the underlying image we are using.
Expand Down
5 changes: 3 additions & 2 deletions examples/3.x/.lando.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: lando-ruby-3
services:
defaults:
type: ruby:3.3
type: ruby:3.4
command: ruby /app/server.rb
custom:
type: ruby:3.1
Expand All @@ -15,7 +15,8 @@ services:
type: ruby:3.2
v3_3:
type: ruby:3.3

v3_4:
type: ruby:3.4

# This is important because it lets lando know to test against the plugin in this repo
# DO NOT REMOVE THIS!
Expand Down
4 changes: 2 additions & 2 deletions examples/3.x/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ Verification commands
Run the following commands to validate things are rolling as they should.

```bash
# Should use 3.3.x as the defined version
lando ssh -s defaults -c "ruby --version | grep 3.3."
# Should use 3.4.x as the defined version
lando ssh -s defaults -c "ruby --version | grep 3.4."

# Should use 3.1.x as the defined version
lando ssh -s custom -c "ruby --version | grep 3.1."
Expand Down

0 comments on commit dff06bd

Please sign in to comment.