Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate AppMap #82

Closed
wants to merge 3 commits into from
Closed

Integrate AppMap #82

wants to merge 3 commits into from

Conversation

dustinbyrne
Copy link

No description provided.

@github-actions
Copy link

AppMap configuration report

Success! Your project has been successfully configured to record AppMaps when
you run your tests.

Continue with AppMap Setup >>


View details

AppMap data sources

In GitHub Actions and other CI systems, AppMaps are created by recording
test cases. Here's how the AppMaps in this project were created:

Number of AppMaps Type of recording
67 minitest

Code profile

Your appmap.yml configuration file specifies all the code that you want AppMap to instrument and record.
By default, sub-modules of any requested code are recorded as well. In this project, the packages specified
in appmap.yml are:

- path: app
- path: lib

By applying this configuration to your ruby project, AppMap has recorded the
following packages and modules:

app app/helpers app/models

Web service API profile

When you record AppMaps that include HTTP server requests, AppMap automatically generates OpenAPI definitions
based on the observed data.

61% of the AppMaps in this project contain at least one HTTP server request.

31% of the AppMaps in this project contain more than one HTTP server request.

Here's a summary of the web service routes that are provided by this project:

/ /about /account_activations/{id} /contact /help /login /logout /microposts /microposts/{id} /password_resets /password_resets/new /password_resets/{id} /relationships /relationships/{id} /signup /users /users/{id}

And here are the different content types served by the API:

Response Content Type Number of Routes
text/html 37
text/javascript 2

As you change your code and tests, AppMap will automatically update the OpenAPI definitions.
You'll see a summary of the REST API changes in each pull request.

SQL profile

When your code makes a SQL query, AppMap records the SQL query in detail. It even parses the queries
to figure out which tables your app is using, and how it's using them.

75% of the AppMaps in this project contain at least one SQL query.

73% of the AppMaps in this project contain more than one SQL query.

Here are the SQL tables that are present in the observed queries:

active_storage_attachments active_storage_blobs microposts relationships sqlite_master sqlite_temp_master users

Learn more

To learn more about AppMap, visit
appmap.io/docs.

@github-actions
Copy link

AppMap pull request analysis

Summary Status
Failed tests ✅ All tests passed
API changes 0️⃣ No API changes
Security flaws 🔒 1 new 🎉 1 resolved
Performance problems ✅ None detected
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

Security flaws

🔒 New problems detected (1)

Execution of untrusted system command
Description

Open3.capture3 executes an untrusted command string

Field Value
Rule exec-of-untrusted-command
Impact domain Security
View in AppMap
Stack trace
  • /opt/hostedtoolcache/Ruby/3.0.2/x64/lib/ruby/3.0.0/open3.rb:279
  • app/views/users/new.html.erb
  • vendor/bundle/ruby/3.0.0/gems/actionpack-6.0.4.1/lib/action_controller/metal/renderers.rb:141
  • vendor/bundle/ruby/3.0.0/gems/actionpack-6.0.4.1/lib/action_controller/metal/instrumentation.rb:19

🎉 Problems resolved (1)

Execution of untrusted system command
Description

Open3.capture3 executes an untrusted command string

Field Value
Rule exec-of-untrusted-command
Impact domain Security
View in AppMap
Stack trace
  • /opt/hostedtoolcache/Ruby/3.0.2/x64/lib/ruby/3.0.0/open3.rb:279
  • app/views/users/edit.html.erb
  • vendor/bundle/ruby/3.0.0/gems/actionpack-6.0.4.1/lib/action_controller/metal/renderers.rb:141
  • vendor/bundle/ruby/3.0.0/gems/actionpack-6.0.4.1/lib/action_controller/metal/instrumentation.rb:19

@dustinbyrne dustinbyrne deleted the appmap-ci branch October 26, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant