Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Dataset Overwrite, and Version Checkout #496

Merged
merged 8 commits into from
Jan 31, 2023
Merged

[Rust] Dataset Overwrite, and Version Checkout #496

merged 8 commits into from
Jan 31, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jan 31, 2023

Closes #491 and #492

@eddyxu eddyxu requested a review from changhiskhan January 31, 2023 05:41
@eddyxu eddyxu self-assigned this Jan 31, 2023
@eddyxu eddyxu added python arrow Apache Arrow related issues rust Rust related tasks labels Jan 31, 2023
let dataset = rt.block_on(async { LanceDataset::open(uri.as_str()).await });
let dataset = rt.block_on(async {
if let Some(ver) = version {
LanceDataset::checkout(uri.as_str(), ver).await
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's expose checkout to python? Can be done in separate PR tho

@eddyxu
Copy link
Contributor Author

eddyxu commented Jan 31, 2023

The dataset checkout api in python is exposed via lance.dataset(uri, version=None) . which is consistent with the old API? Python has this default kw args, feel that it is more pythonic , wdyt.

@eddyxu eddyxu merged commit 85fa380 into main Jan 31, 2023
@eddyxu eddyxu deleted the lei/ds_create branch January 31, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Apache Arrow related issues python rust Rust related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rust] Implement Dataset::Write(Create)
2 participants