Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast count rows #490

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Fast count rows #490

merged 4 commits into from
Jan 30, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jan 30, 2023

No description provided.

@eddyxu eddyxu requested a review from changhiskhan January 30, 2023 17:58
changhiskhan
changhiskhan reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the pyo3 integration too? the function is setup in python, just need to thread the call down from LanceDataset (python) -> pylance Dataset (rust) -> Lance Dataset::len. And add a quick unit test from python side.

@eddyxu
Copy link
Contributor Author

eddyxu commented Jan 30, 2023

Can you add the pyo3 integration too? the function is setup in python, just need to thread the call down from LanceDataset (python) -> pylance Dataset (rust) -> Lance Dataset::len. And add a quick unit test from python side.

Will do in a separate PR.

changhiskhan
changhiskhan approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, the python will be in separate PR

@eddyxu eddyxu merged commit 93fb8b1 into main Jan 30, 2023
@eddyxu eddyxu deleted the lei/count_rows branch January 30, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @changhiskhan