[Rust] Minimal dataset append support #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changhiskhan
approved these changes
Jan 29, 2023
| @@ -175,7 +175,7 @@ mod tests { | |||
| let mut params = WriteParams::default(); | |||
| params.max_rows_per_group = 10; | |||
| let mut reader: Box<dyn RecordBatchReader> = Box::new(batches); | |||
| Dataset::create(&mut reader, path, Some(params)) | |||
| Dataset::write(&mut reader, path, Some(params)) | |||
There was a problem hiding this comment.
I think pyo3 will break on the name change. Don't have GHA yet for this so it's annoying. I will try to add it tonight
There was a problem hiding this comment.
Oh, that's nice. Thanks.
| } | ||
| } | ||
|
|
||
| let mut fragment_id = latest_manifest.as_ref().map_or(0, |m| { |
There was a problem hiding this comment.
would it make sense to put max fragment in manifest?
There was a problem hiding this comment.
This is interesting about how to enforce it. i.e., allow a background thread to start compact but allow writing, or just hard stop users to append new fragments.
This could be a question we need to answer when the scale is up.
Is this the same concept as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back Append support in schema evolution