L2 distance #439
Merged
L2 distance #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
added
arrow
|
|
||
| /// Euclidean Distance (L2) from a point to a list of points. | ||
| pub fn l2_distance(from: &Float32Array, to: &FixedSizeListArray) -> Result<Arc<Float32Array>> { | ||
| assert_eq!(from.len(), to.value_length() as usize); |
There was a problem hiding this comment.
do these stay in production? These panic right? Should these return Err in stead?
There was a problem hiding this comment.
These are not error, but bugs. Err is catchable & recoverable by the users, this is not the case?
rust/src/utils/distance.rs
Outdated
| pub fn l2_distance(from: &Float32Array, to: &FixedSizeListArray) -> Result<Arc<Float32Array>> { | ||
| assert_eq!(from.len(), to.value_length() as usize); | ||
| assert_eq!(to.value_type(), DataType::Float32); | ||
| assert_eq!( |
There was a problem hiding this comment.
this seems like an odd constraint no? shouldn't there be a non-optimized case that can deal with non-multiples?
There was a problem hiding this comment.
Ok, added a fallback to non SIMD route for odd length vectors.
changhiskhan
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
std::archprovided by the stable Rust. We could usestd::simdwhen it is ready for stable rust.Note that, I did not hand write simd for M1 / Aarch64 yet,
std::arch::aarch64seems not stable at the moment. Also, no BLAS-based performance is tested so that there is no extra dependency for Lance.