Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prototype SQL API #3132

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

westonpace
Copy link
Contributor

This is a basic prototype for SQL queries. I'm a bit torn if it's useful. I think we can soon support datafusion-python. Once we can then users will have the choice of both datafusion-python and duckdb. I'm not sure if there's value in also maintaining a simple no-dependency endpoint for SQL queries.

@github-actions github-actions bot added enhancement New feature or request python labels Nov 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (f257489) to head (faedd7e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/datafusion/sql.rs 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
- Coverage   77.91%   77.89%   -0.03%     
==========================================
  Files         240      241       +1     
  Lines       81564    81479      -85     
  Branches    81564    81479      -85     
==========================================
- Hits        63550    63465      -85     
- Misses      14806    14838      +32     
+ Partials     3208     3176      -32     
Flag Coverage Δ
unittests 77.89% <20.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants