Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV parsing fails when there is an ISO date rounded by text in a column #111

Closed
lana-k opened this issue Jun 29, 2023 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lana-k
Copy link
Owner

lana-k commented Jun 29, 2023

Papaparse used the wrong regular expression for recognising date columns (see mholt/PapaParse#959). As a result a string like this "some text 2023-05-05T15:30:00Z some text" was interpreted as a date and Papaparse tried to convert it into Date instance and got Invalid date.
After parsing sqliteviz converts all Date instances into ISO string in order to make it work in sqlite DB. It failed when applied against Invalid date.

In version 5.4.0 Papaparse fixed the regular expression, so strings like "some text 2023-05-05T15:30:00Z some text" are not interpreted as dates anymore.

Update Papaparse in sqliteviz.

@lana-k lana-k added the bug Something isn't working label Jun 29, 2023
@lana-k lana-k added this to the v0.23.1 milestone Jun 29, 2023
@lana-k lana-k self-assigned this Jun 29, 2023
lana-k added a commit that referenced this issue Jun 29, 2023
@lana-k lana-k closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant