Show image loading errors to the user #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for your work on
egui_commonmark
!In this PR I've added support for showing image loading errors to the user:
To implement this I added a dependency on the
poll-promise
crate. An added benefit is that we can also show a loading spinner while an image is being downloaded:I also changed the
Mutex
to the one fromparking_lot
.egui
already depends onparking_lot
, so it is no added dependency, and it is much more ergonomic (no need for.unwrap()
everywhere).I split the code in a few files - hope that's ok.