Fix #14576: Ensure unreported warning summaries are also emitted via sbt-bridge #14602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice PR! |
adpi2
reviewed
Mar 2, 2022
|
Thanks, I understand why people are grateful when they open a ticket and someone fixes it. I will make time to study this PR, or I'll wait for the Coursera on "How do I even test this?" |
adpi2
approved these changes
Mar 3, 2022
The sbt-bridge uses a delegating reporter that overrides the base implementation of `printSummary` and delegates to the sbt implementation. However that implementation only provides summary reporting of warning and error counts, and the _compiler_ is responsible for emitting any summary diagnostics regarding unreported warnings. This commit separates emitting those unreported warning summaries from the base implementation of Reporter#printSummary so as not to be overriden by the DelegatingReporter in sbt-bridge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sbt-bridge uses a delegating reporter that overrides the base implementation of
printSummaryand delegates to the sbt implementation.However that implementation only provides summary reporting of warning and error counts, and the compiler is responsible for emitting any summary diagnostics regarding unreported warnings.
This commit separates emitting those unreported warning summaries from the base implementation of
Reporter#printSummaryso as not to be overriden by the DelegatingReporter in sbt-bridge.Fixes #14576