Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generation configuration in sbt. Generate reference documentation using Scaladoc #14489

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

pikinier20
Copy link
Contributor

No description provided.

@pikinier20 pikinier20 force-pushed the scaladoc/generation-refactor branch 4 times, most recently from f69c2d1 to 3a99f4b Compare February 16, 2022 12:10
@pikinier20 pikinier20 force-pushed the scaladoc/generation-refactor branch from 3a99f4b to e92666b Compare February 16, 2022 12:38
import sbt._
import Build._

object ScaladocGeneration {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this could be used in SBT plugin as an alternative to configure Scaladoc

val overrideFunc = outputDirOverride.andThen(justAPI)

val config = Def.task {
overrideFunc(Scala3.value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Just using Scala 3 here looks strange, I would prefix it with ScaladocSettings.Scala3

@pikinier20 pikinier20 marked this pull request as ready for review February 18, 2022 07:35
Copy link
Contributor

@BarkingBad BarkingBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pikinier20 pikinier20 merged commit 20dadc7 into scala:main Feb 22, 2022
@pikinier20 pikinier20 deleted the scaladoc/generation-refactor branch February 22, 2022 10:48
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants