Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Composer installation command for laminas-paginator-adapter-laminasdb #69

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

gabrielpcruz
Copy link
Contributor

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

The current code is:

composer require laminas/laminas-paginator laminas-paginator-adapter-laminasdb

But it is getting an error:

root@090fdd4c9695:/var/www/html# composer require laminas/laminas-paginator laminas-paginator-adapter-laminasdb

In VersionParser.php line 521:
                                                                                                                                        
Could not parse version constraint laminas-paginator-adapter-laminasdb: Invalid version string "laminas-paginator-adapter-laminasdb" 

The PR just adjust it for put "laminas/" prefix:

composer require laminas/laminas-paginator laminas/laminas-paginator-adapter-laminasdb

The current code is:

``` composer require laminas/laminas-paginator laminas-paginator-adapter-laminasdb ```

But it is getting an error:

root@090fdd4c9695:/var/www/html# composer require laminas/laminas-paginator laminas-paginator-adapter-laminasdb

In VersionParser.php line 521:
                                                                                                                                        
Could not parse version constraint laminas-paginator-adapter-laminasdb: Invalid version string "laminas-paginator-adapter-laminasdb" 

The PR just adjust it for put "laminas/" prefix

Signed-off-by: Gabriel Cruz <[email protected]>
@froschdesign froschdesign added the Bug Something isn't working label Sep 10, 2024
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍🏻

@froschdesign froschdesign changed the title Update pagination.md Wrong Composer installation command for laminas-paginator-adapter-laminasdb Sep 10, 2024
@froschdesign froschdesign merged commit 5bb80cc into laminas:master Sep 10, 2024
1 check passed
@froschdesign
Copy link
Member

@gabrielpcruz
Thank you for your time and this contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants