Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integers fail validation with Digits validator #402

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fix integers fail validation with Digits validator #402

merged 1 commit into from
Nov 29, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Nov 28, 2024

Adds a fix for integers failing validation with the Digits validator and improves tests with additional test cases

@gsteel gsteel added Bug Something isn't working Review Needed labels Nov 28, 2024
@gsteel gsteel added this to the 3.0.1 milestone Nov 28, 2024
@gsteel gsteel linked an issue Nov 28, 2024 that may be closed by this pull request
Digits does not accept integers like 2.x did #401
Closed
@gsteel gsteel requested a review from froschdesign November 28, 2024 23:09
@gsteel gsteel self-assigned this Nov 29, 2024
@gsteel gsteel merged commit ab6f456 into laminas:3.0.x Nov 29, 2024
15 checks passed
@gsteel gsteel deleted the digits-regression branch November 29, 2024 09:36
@gsteel gsteel mentioned this pull request Nov 29, 2024
Closed
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhimede arhimede arhimede approved these changes

@froschdesign froschdesign Awaiting requested review from froschdesign

Assignees

@gsteel gsteel

Labels
Bug Something isn't working
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

Digits does not accept integers like 2.x did
2 participants
@gsteel @arhimede