Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Iban validator #322

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Refactor Iban validator #322

merged 1 commit into from
Jul 3, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 3, 2024

Q A
Documentation yes
BC Break yes
QA yes

Description

  • Remove getters and setters
  • Accepts only an options array to the constructor
  • Improve docs
  • Improve coverage
  • Add types

@gsteel gsteel added this to the 3.0.0 milestone Jul 3, 2024
gsteel added a commit to gsteel/laminas-validator that referenced this pull request Jul 3, 2024
See laminas#322

Signed-off-by: George Steel <[email protected]>
@gsteel gsteel mentioned this pull request Jul 3, 2024
@gsteel gsteel force-pushed the v3/refactor-iban branch from 83c73c3 to 389ca7b Compare July 3, 2024 14:17
- Remove getters and setters
- Accepts only an options array to the constructor
- Improve docs
- Improve coverage
- Add types

Signed-off-by: George Steel <[email protected]>
@gsteel gsteel force-pushed the v3/refactor-iban branch from 389ca7b to 916aba9 Compare July 3, 2024 14:18
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@gsteel gsteel self-assigned this Jul 3, 2024
@gsteel gsteel merged commit 2c2d75a into laminas:3.0.x Jul 3, 2024
14 of 15 checks passed
@gsteel gsteel deleted the v3/refactor-iban branch July 3, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants