Refactor ISBN validator
#316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes option setters and getters - Drops the `separator` option in favour of stripping them from the input - Inlines checksum calculation, removing unnecessary classes - Adds types - Accept only an options array to the constructor - Simplify tests with data providers Signed-off-by: George Steel <[email protected]>
gsteel
added a commit
to gsteel/laminas-validator
that referenced
this pull request
Jul 3, 2024
More info in laminas#316 Signed-off-by: George Steel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
separatoroption in favour of stripping them from the input