Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported PSR-7 in File\Count validator #109

Closed
wants to merge 4 commits into from

Conversation

icetee
Copy link
Contributor

@icetee icetee commented Sep 9, 2021

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

This PR complements previous PR zendframework/zend-validator#251. Recommendation PSR-7 UploadedFileInterface has not been implemented in File / Count validation. At the same time, it improves the #24 issue.

@icetee icetee force-pushed the feature/count-psr7 branch from ab826e0 to e469faa Compare September 9, 2021 14:08
Signed-off-by: Tamás András Horváth <[email protected]>
@icetee icetee force-pushed the feature/count-psr7 branch from e469faa to f355323 Compare September 9, 2021 14:14
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this: good improvement.

Missing an unhappy path with an UploadedFileInterface though 🤔

@Ocramius
Copy link
Member

Also: sorry for not noticing the patch before :\

@icetee
Copy link
Contributor Author

icetee commented Oct 11, 2022

I need to change something? @Ocramius

@Ocramius
Copy link
Member

I think a false scenario in the validator test would be good here

@icetee icetee changed the base branch from 2.16.x to 2.27.x October 16, 2022 22:18
@icetee
Copy link
Contributor Author

icetee commented Oct 16, 2022

I updated the base version (2.27.x), let's continue here #158

@icetee icetee closed this Oct 16, 2022
@Ocramius Ocramius added the Duplicate This issue or pull request already exists label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Author Updates Duplicate This issue or pull request already exists Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants