Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4 #43

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

Atul-glo35265
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

@Atul-glo35265
Copy link
Contributor Author

Atul-glo35265 commented Oct 17, 2024

@froschdesign Kindly review the PR once and do needful.

@Atul-glo35265
Copy link
Contributor Author

@gsteel, kindly review this PR once and merge it, if possible.

Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

src/AutoDiscover.php Outdated Show resolved Hide resolved
src/AutoDiscover.php Outdated Show resolved Hide resolved
@froschdesign
Copy link
Member

@Atul-glo35265
The problem is amphp/amp, so instead of upgrading PHPUnit to version 10, which introduces new problems, add older versions of amphp/amp as a conflict:

"conflict": {
    "amphp/amp":"<2.6.4"
}

Signed-off-by: Atul-glo35265 <[email protected]>
@Atul-glo35265
Copy link
Contributor Author

@Atul-glo35265 The problem is amphp/amp, so instead of upgrading PHPUnit to version 10, which introduces new problems, add older versions of amphp/amp as a conflict:

"conflict": {
    "amphp/amp":"<2.6.4"
}

Thank you @froschdesign. Please review once and do the needful.

@nishant04412
Copy link

@gsteel Please check and advise if this looks good or anything else needs to be addressed ?

@froschdesign
Copy link
Member

@nishant04412
Please stop pinging people. It is done when it is done.


You can have a look at the tests and maybe you can explain why the change is necessary.

@froschdesign
Copy link
Member

@Atul-glo35265
Please check the history to see if the test included this check from the beginning or if it was changed at some point.

@Atul-glo35265
Copy link
Contributor Author

@Atul-glo35265 Please check the history to see if the test included this check from the beginning or if it was changed at some point.

It was added by @glo71317 while adding support for PHP8.3. Please check here.
It was causing test failure while adding support for PHP 8.4, so I reverted it.

@gsteel gsteel self-assigned this Nov 29, 2024
@gsteel gsteel added this to the 2.14.0 milestone Nov 29, 2024
@gsteel gsteel merged commit f8a7844 into laminas:2.14.x Nov 29, 2024
16 of 17 checks passed
@gsteel gsteel changed the title Php8.4 support added Add support for PHP 8.4 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants