-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 8.4 #43
Conversation
@froschdesign Kindly review the PR once and do needful. |
@gsteel, kindly review this PR once and merge it, if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
3e78367
to
6ed98b4
Compare
@Atul-glo35265 "conflict": {
"amphp/amp":"<2.6.4"
} |
Signed-off-by: Atul-glo35265 <[email protected]>
aea3c2a
to
6c555bb
Compare
Thank you @froschdesign. Please review once and do the needful. |
@gsteel Please check and advise if this looks good or anything else needs to be addressed ? |
@nishant04412 You can have a look at the tests and maybe you can explain why the change is necessary. |
@Atul-glo35265 |
It was added by @glo71317 while adding support for PHP8.3. Please check here. |
Signed-off-by: Atul-glo35265 <[email protected]>
Signed-off-by: Atul-glo35265 <[email protected]>
Description