Revert removal of checks for the SID constant deprecated in PHP 8.4

[mimmi20]

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	no

Fixes #97

Description

In Release 2.22.0 the check for the Constant SID was removed. This lead to the error that the Session could not be started when a session ID was set.

[mimmi20]

@froschdesign @gsteel There are two tests failing now (testSessionExistsReturnsTrueWhenSessionStartedThenWritten and testCallingWriteCloseShouldNotAlterSessionExistsStatus).

I dont unserstand why session_write_close shall not change the Session-exists-Status.

PHP's page states

session_write_close
(PHP 4 >= 4.0.4, PHP 5, PHP 7, PHP 8)

session_write_close — Write session data and end session

[gsteel]

I dont unserstand why session_write_close shall not change the Session-exists-Status.

Closing the session persists the session data for the next request, it doesn't kill the session; There is still an active session once it has been written to storage.

To kill the active session, it must be destroyed with session_destroy() or $manager->destroy()

[gsteel]

The tests that now emit deprecations on 8.4 can be silenced by annotating the test with #[IgnoreDeprecations]

[mimmi20]

@gsteel Please review again.

[gsteel]

Thanks @mimmi20

I'm going to merge this as-is. Reverting the previously deleted lines in #94 hopefully fixes your problem.

There's still no test here that fails when the SID constant is defined and the conditional removed, so I'd appreciate it if you could let us know how/why this fixed your issue.