Fix the psalm errors

laminas · Nov 2, 2023 · 00b65c7 · 00b65c7
1 parent f3fd6a8
commit 00b65c7
Show file tree

Hide file tree

Showing 11 changed files with 282 additions and 1 deletion.
diff --git a/.idea/.gitignore b/.idea/.gitignore
diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
diff --git a/.idea/laminas-session.iml b/.idea/laminas-session.iml
diff --git a/.idea/modules.xml b/.idea/modules.xml
diff --git a/.idea/php.xml b/.idea/php.xml
diff --git a/.idea/phpunit.xml b/.idea/phpunit.xml
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -141,6 +141,9 @@
       <code><![CDATA[static fn() => $ts]]></code>
       <code><![CDATA[static fn() => ['hops' => $hops, 'ts' => $ts]]]></code>
     </TooManyArguments>
+    <MethodSignatureMustProvideReturnType occurrences="5">
+      <code>offsetSet</code>
+    </MethodSignatureMustProvideReturnType>
   </file>
   <file src="src/AbstractManager.php">
     <MixedMethodCall>
@@ -393,6 +396,9 @@
     <PropertyNotSetInConstructor>
       <code>Container</code>
     </PropertyNotSetInConstructor>
+    <MethodSignatureMustProvideReturnType>
+      <code>offsetGet</code>
+    </MethodSignatureMustProvideReturnType>
   </file>
   <file src="src/SaveHandler/Cache.php">
     <ImplementedReturnTypeMismatch>
@@ -744,6 +750,10 @@
     <TypeDoesNotContainType>
       <code>is_object($input)</code>
     </TypeDoesNotContainType>
+    <MethodSignatureMustProvideReturnType>
+      <code>serialize</code>
+      <code>unserialize</code>
+    </MethodSignatureMustProvideReturnType>
   </file>
   <file src="src/Storage/ArrayStorage.php">
     <ArgumentTypeCoercion>
@@ -863,6 +873,9 @@
       <code>$_SESSION[$key]</code>
       <code>$_SESSION[$key]</code>
     </MixedArrayOffset>
+    <MethodSignatureMustProvideReturnType>
+      <code>offsetGet</code>
+    </MethodSignatureMustProvideReturnType>
   </file>
   <file src="src/Storage/SessionStorage.php">
     <InvalidArgument>
@@ -1006,6 +1019,14 @@
       <code><![CDATA[$this->expectDeprecation();]]></code>
       <code><![CDATA[$this->expectDeprecation();]]></code>
     </UnevaluatedCode>
+    <UnusedMethodCall>
+      <code>setAccessible</code>
+    </UnusedMethodCall>
+  </file>
+  <file src="test/ReflectionPropertyTrait.php">
+    <UnusedMethodCall>
+      <code>setAccessible</code>
+    </UnusedMethodCall>
   </file>
   <file src="test/Config/StandardConfigTest.php">
     <DeprecatedMethod>
@@ -1465,6 +1486,10 @@
       <code>TestDbTableGatewaySaveHandler</code>
       <code>TestDbTableGatewaySaveHandler</code>
     </PropertyNotSetInConstructor>
+    <MethodSignatureMustProvideReturnType>
+      <code>read</code>
+      <code>destroy</code>
+    </MethodSignatureMustProvideReturnType>
   </file>
   <file src="test/TestAsset/TestManager.php">
     <ImplementedReturnTypeMismatch>

diff --git a/psalm.xml b/psalm.xml
@@ -13,7 +13,13 @@
             <directory name="vendor"/>
         </ignoreFiles>
     </projectFiles>
-
+    <issueHandlers>
+        <DeprecatedClass>
+            <errorLevel type="suppress">
+                <referencedClass name="Laminas\ServiceManager\Config"/>
+            </errorLevel>
+        </DeprecatedClass>
+    </issueHandlers>
     <plugins>
         <pluginClass class="Psalm\PhpUnitPlugin\Plugin"/>
     </plugins>

diff --git a/src/SaveHandler/DbTableGatewayOptions.php b/src/SaveHandler/DbTableGatewayOptions.php
@@ -9,6 +9,7 @@
 
 /**
  * DbTableGateway Save Handler Options
+ * @psalm-suppress MissingTemplateParam
  */
 class DbTableGatewayOptions extends AbstractOptions
 {

diff --git a/src/SaveHandler/MongoDBOptions.php b/src/SaveHandler/MongoDBOptions.php
@@ -13,6 +13,7 @@
 
 /**
  * MongoDB session save handler Options
+ * @psalm-suppress MissingTemplateParam
  */
 class MongoDBOptions extends AbstractOptions
 {
-Original file line number
+Diff line change
@@ Expand Up / @@ -9,6 +9,7 @@ @@
     /**
      * DbTableGateway Save Handler Options
+     * @psalm-suppress MissingTemplateParam
      */
     class DbTableGatewayOptions extends AbstractOptions
     {
@@ Expand Down @@