-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow psr/container 2.0.* #175
Conversation
Should allow psr/container 2.0.2 - not only 1.1.2 Changes: php-fig/container@2.0.2...1.1.2 Signed-off-by: Tobias Meindl <[email protected]>
Signed-off-by: Tobias Meindl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly not as simple as it sounds, as this represents a major BC break for downstream.
Duplicate of #151 |
@Ocramius could you please explain why adding a new allowed version is a "major BC break for downstream" - the change in the psr/container is not a major BC in my opinion. |
This snippet makes it more clear: https://3v4l.org/DfZYG <?php
class ServiceManager {
function has($name): bool { return true; }
}
final class UserlandContainer extends ServiceManager
{
function has($name) { return true; }
}
|
So this change will only take place with the (next?) Major Version release of laminas-servicemanager? Edit: Thanks for the example! :) |
Correct. See also the related milestone for the next major version. |
Should allow psr/container 2.0.2 - not only 1.1.2
Changes:
php-fig/container@2.0.2...1.1.2
Can close after merge: #151
Description