-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
psr/container v2 breaks other components #146
Comments
Indeed, seen in laminas/laminas-feed#59 It's generally super-annoying, so we're thinking of rolling back |
Meanwhile, configuring renovate on |
Hmm, I think Will adjust. |
…ol` instead of `null` This is necessary, as `psr/container:^2` has a stricter return type declaration, and prophecy is not respecting the return types upfront (unless stubbed methods are explicitly configured). While this is an upstream BC break in `psr/container:^2`, this component is not really affected by the BC issue, other than some stubbing being broken in it. Fixes: ``` 1) LaminasTest\InputFilter\InputFilterPluginManagerFactoryTest::testFactoryConfiguresPluginManagerUnderContainerInterop with data set "input" ('Laminas\InputFilter\InputInterface') TypeError: Double\ContainerInterface\P8::has(): Return value must be of type bool, null returned 2) LaminasTest\InputFilter\InputFilterPluginManagerFactoryTest::testFactoryConfiguresPluginManagerUnderContainerInterop with data set "input-filter" ('Laminas\InputFilter\InputFilt...erface') TypeError: Double\ContainerInterface\P8::has(): Return value must be of type bool, null returned ``` Ref: laminas/laminas-servicemanager#146 (comment) Ref: laminas/laminas-servicemanager#146 (comment)
Closing here, fixed in Although the issue with Please report other failures as you encounter them 👍 |
Ref: #147 |
https://github.com/laminas/laminas-servicemanager/releases/tag/3.15.1 should fix this: sad to see that work reverted, but our hopes that it would work were unfounded. |
Since v2 is allowed, example for laminas-inputfilter
And then
Other components may be affected (laminas-hydrator, laminas-servicemanager-di)
despite these have no direct dependency on psr/container
The text was updated successfully, but these errors were encountered: