Deprecate Json adapter, as laminas-json is abandoned
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Riehle <[email protected]>
This was referenced Jan 24, 2025
|
I have provided the update of the docs as a separate PR in #75, as that can go directly in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #72. Marks the
Jsonadapter, which uses laminas-json, as deprecated.Should go into
2.18.xand3.2.xwith the relevant classes to be dropped in 4.0.What, to me, seems to be a bit of a downside is that we cannot make a new laminas-serializer release dropping laminas-json for laminas-servicemanager v3. This is because laminas-serializer v3 with support for laminas-servicemanger v4 has already been released, so there is no version number anymore to make BC breaks in the laminas-serializer v2 series. This is not yet a real issue, but it would become an issue if PHP 8.5 was released before the whole Laminas ecosystems is on servicemanger v4, because then we would need a new release of the abandoned laminas-json, to keep our applications running.