Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal stub for psr container, updating export-ignores #192

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Oct 14, 2022

Q A
Documentation yes
New Feature yes
QA yes

Description

Adding the stub doesn't have much impact here because most of the get's use aliases. It'll probably be more useful when psalm.xml goes to level 1 perhaps?

Would you accept a PR to update calls to $container->get('FormElementManager') to $container->get(FormElementManager::class) (And similar) ???

@Slamdunk
Copy link
Contributor

Would you accept a PR to update calls to $container->get('FormElementManager') to $container->get(FormElementManager::class) (And similar) ???

Yes please, we can also switch the official ones to be the class names, so from:

'aliases'            => [
    Annotation\AnnotationBuilder::class => 'FormAnnotationBuilder',
    Annotation\AttributeBuilder::class  => 'FormAttributeBuilder',
    FormElementManager::class           => 'FormElementManager',
],
'factories'          => [
    'FormAnnotationBuilder' => Annotation\BuilderAbstractFactory::class,
    'FormAttributeBuilder'  => Annotation\BuilderAbstractFactory::class,
    'FormElementManager'    => FormElementManagerFactory::class,
],

to

'aliases'            => [
    'FormAnnotationBuilder' => Annotation\AnnotationBuilder::class,
    'FormAttributeBuilder'  => Annotation\AttributeBuilder::class,
    'FormElementManager'    => FormElementManager::class,
],
'factories'          => [
    Annotation\AnnotationBuilder::class => Annotation\BuilderAbstractFactory::class,
    Annotation\AttributeBuilder::class  => Annotation\BuilderAbstractFactory::class,
    FormElementManager::class           => FormElementManagerFactory::class,
],

@Slamdunk Slamdunk self-assigned this Oct 14, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 here meanwhile.

Thanks @gsteel!

@Ocramius Ocramius assigned Ocramius and unassigned Slamdunk Oct 14, 2022
@Ocramius Ocramius merged commit 477695f into laminas:3.5.x Oct 14, 2022
@gsteel gsteel deleted the container-stub branch October 14, 2022 11:29
froschdesign added a commit to froschdesign/laminas-form that referenced this pull request Oct 26, 2022
Add internal stub for psr container, updating export-ignores

Signed-off-by: Frank Brückner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants