Improve type inference for FormElementManager #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gsteel
commented
Oct 14, 2022
gsteel
commented
| Q | A |
|---|---|
| Documentation | yes |
| New Feature | yes |
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Slamdunk
reviewed
Oct 14, 2022
| @@ -22,6 +22,8 @@ | |||
| * laminas-servicemanager v3-compatible plugin manager implementation for form elements. | |||
| * | |||
| * Enforces that elements retrieved are instances of ElementInterface. | |||
| * | |||
| * @extends AbstractPluginManager<ElementInterface> | |||
There was a problem hiding this comment.
May I ask you why here the @extends is simple, while on laminas-validator you opted for
* @template InstanceType of ValidatorInterface
* @extends AbstractPluginManager<InstanceType>
?
There was a problem hiding this comment.
I think validator should have taken the same approach, i.e. not define a custom type. Custom types are useful, for example, in View and Filter where the type can be HelperInterface|callable()|SomethingElse - in this case it's only ever going to be an ElementInterface so the custom type was unnecessary.
Slamdunk
approved these changes
Oct 14, 2022
|
Thank you @gsteel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.