Remove container-interop/container-interop in favour of psr/container
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internalsystemerror
force-pushed
the
remove-container-interop
branch
from
8699cb3 to
680f57b
Compare
Ocramius
requested changes
Jul 17, 2022
froschdesign
requested changes
Jul 17, 2022
internalsystemerror
force-pushed
the
remove-container-interop
branch
2 times, most recently
from
0245605 to
8dd4c62
Compare
internalsystemerror
force-pushed
the
remove-container-interop
branch
from
c00df4f to
6a8d463
Compare
|
A couple of questions:
|
Ocramius
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Besides worsened type inference, this is OK as-is, @internalsystemerror 👍
Comment on lines
+367
to
+376
| <PossiblyUndefinedArrayOffset occurrences="1"> | ||
| <code>$inputSpec['validators']</code> | ||
| </PossiblyUndefinedArrayOffset> | ||
| </file> | ||
| <file src="test/Element/CheckboxTest.php"> | ||
| <PossiblyInvalidMethodCall occurrences="1"> | ||
| <code>getHaystack</code> | ||
| </PossiblyInvalidMethodCall> | ||
| <PossiblyUndefinedArrayOffset occurrences="1"> | ||
| <code>$inputSpec['validators']</code> | ||
| </PossiblyUndefinedArrayOffset> | ||
| <UndefinedInterfaceMethod occurrences="1"> | ||
| <code>getHaystack</code> | ||
| </UndefinedInterfaceMethod> |
There was a problem hiding this comment.
Inference regressed here: can we investigate why?
There was a problem hiding this comment.
This is just as I was saying above (afaik) that this is what is being tested for. So I'm not sure why these are showing now and not before (my theory: better types in the docblocks in src).
gsteel
requested changes
Oct 31, 2022
added 3 commits
November 21, 2022 12:58
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
internalsystemerror
force-pushed
the
remove-container-interop
branch
from
f891b57 to
9702453
Compare
Signed-off-by: Gary Lockett <[email protected]>
internalsystemerror
force-pushed
the
remove-container-interop
branch
from
9702453 to
bc9a1be
Compare
|
Unused type import remove, rebased to the latest changes in Should be ready for rereview now 👍 |
Ocramius
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #171