Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend global attributes array #175

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Extend global attributes array #175

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62e65d3
Extend global attributes array
Koopzington Jul 6, 2022
b7e93c6
Added links to the HTML spec on each attribute
Koopzington Jul 7, 2022
211c5b4
Change links to live version to cut down line length
Koopzington Jul 7, 2022
b9e8658
CS Fix
Slamdunk Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
177 changes: 93 additions & 84 deletions src/View/Helper/AbstractHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ abstract class AbstractHelper extends BaseAbstractHelper
* @var array
*/
protected $booleanAttributes = [
'autofocus' => ['on' => 'autofocus', 'off' => ''],
'checked' => ['on' => 'checked', 'off' => ''],
'disabled' => ['on' => 'disabled', 'off' => ''],
'itemscope' => ['on' => 'itemscope', 'off' => ''],
'multiple' => ['on' => 'multiple', 'off' => ''],
'readonly' => ['on' => 'readonly', 'off' => ''],
'required' => ['on' => 'required', 'off' => ''],
'selected' => ['on' => 'selected', 'off' => ''],
'autofocus' => ['on' => 'autofocus', 'off' => ''], // https://html.spec.whatwg.org/#attr-fe-autofocus
'checked' => ['on' => 'checked', 'off' => ''], // https://html.spec.whatwg.org/#attr-input-checked
'disabled' => ['on' => 'disabled', 'off' => ''], // https://html.spec.whatwg.org/#attr-fe-disabled
'itemscope' => ['on' => 'itemscope', 'off' => ''], // https://html.spec.whatwg.org/#attr-itemscope
'multiple' => ['on' => 'multiple', 'off' => ''], // https://html.spec.whatwg.org/#attr-input-multiple
'readonly' => ['on' => 'readonly', 'off' => ''], // https://html.spec.whatwg.org/#attr-input-readonly
'required' => ['on' => 'required', 'off' => ''], // https://html.spec.whatwg.org/#attr-input-required
'selected' => ['on' => 'selected', 'off' => ''], // https://html.spec.whatwg.org/#attr-option-selected
];

/**
Expand Down Expand Up @@ -92,80 +92,89 @@ abstract class AbstractHelper extends BaseAbstractHelper
* @var array
*/
protected $validGlobalAttributes = [
'accesskey' => true,
'class' => true,
'contenteditable' => true,
'contextmenu' => true,
'dir' => true,
'draggable' => true,
'dropzone' => true,
'hidden' => true,
'id' => true,
'itemprop' => true,
'itemscope' => true,
'itemtype' => true,
'lang' => true,
'onabort' => true,
'onblur' => true,
'oncanplay' => true,
'oncanplaythrough' => true,
'onchange' => true,
'onclick' => true,
'oncontextmenu' => true,
'ondblclick' => true,
'ondrag' => true,
'ondragend' => true,
'ondragenter' => true,
'ondragleave' => true,
'ondragover' => true,
'ondragstart' => true,
'ondrop' => true,
'ondurationchange' => true,
'onemptied' => true,
'onended' => true,
'onerror' => true,
'onfocus' => true,
'oninput' => true,
'oninvalid' => true,
'onkeydown' => true,
'onkeypress' => true,
'onkeyup' => true,
'onload' => true,
'onloadeddata' => true,
'onloadedmetadata' => true,
'onloadstart' => true,
'onmousedown' => true,
'onmousemove' => true,
'onmouseout' => true,
'onmouseover' => true,
'onmouseup' => true,
'onmousewheel' => true,
'onpause' => true,
'onplay' => true,
'onplaying' => true,
'onprogress' => true,
'onratechange' => true,
'onreadystatechange' => true,
'onreset' => true,
'onscroll' => true,
'onseeked' => true,
'onseeking' => true,
'onselect' => true,
'onshow' => true,
'onstalled' => true,
'onsubmit' => true,
'onsuspend' => true,
'ontimeupdate' => true,
'onvolumechange' => true,
'onwaiting' => true,
'role' => true,
'spellcheck' => true,
'style' => true,
'tabindex' => true,
'title' => true,
'xml:base' => true,
'xml:lang' => true,
'xml:space' => true,
'accesskey' => true, // https://html.spec.whatwg.org/#the-accesskey-attribute
'autocapitalize' => true, // https://html.spec.whatwg.org/#attr-autocapitalize
'class' => true, // https://html.spec.whatwg.org/#classes
'contenteditable' => true, // https://html.spec.whatwg.org/#contenteditable
'contextmenu' => true, // Obsolete: https://html.spec.whatwg.org/#attr-contextmenu
'dir' => true, // https://html.spec.whatwg.org/#the-dir-attribute
'draggable' => true, // https://html.spec.whatwg.org/#the-draggable-attribute
'dropzone' => true, // Obsolete: https://html.spec.whatwg.org/#attr-dropzone
'enterkeyhint' => true, // https://html.spec.whatwg.org/#input-modalities:-the-enterkeyhint-attribute
'hidden' => true, // https://html.spec.whatwg.org/#the-hidden-attribute
'id' => true, // https://html.spec.whatwg.org/#the-id-attribute
'inputmode' => true, // https://html.spec.whatwg.org/#attr-inputmode
'is' => true, // https://html.spec.whatwg.org/#attr-is
//'itemid' => true, // https://html.spec.whatwg.org/#attr-itemid
'itemprop' => true, // https://html.spec.whatwg.org/#names:-the-itemprop-attribute
'itemref' => true, // https://html.spec.whatwg.org/#attr-itemref
'itemscope' => true, // https://html.spec.whatwg.org/#attr-itemscope
'itemtype' => true, // https://html.spec.whatwg.org/#attr-itemtype
'lang' => true, // https://html.spec.whatwg.org/#the-lang-and-xml:lang-attributes
//'nonce' => true, // https://html.spec.whatwg.org/#attr-nonce
'onabort' => true, // https://html.spec.whatwg.org/#handler-onabort
'onblur' => true, // https://html.spec.whatwg.org/#handler-onblur
'oncanplay' => true, // https://html.spec.whatwg.org/#handler-oncanplay
'oncanplaythrough' => true, // https://html.spec.whatwg.org/#handler-oncanplaythrough
'onchange' => true, // https://html.spec.whatwg.org/#handler-onchange
'onclick' => true, // https://html.spec.whatwg.org/#handler-onclick
'oncontextmenu' => true, // https://html.spec.whatwg.org/#handler-oncontextmenu
'ondblclick' => true, // https://html.spec.whatwg.org/#handler-ondblclick
'ondrag' => true, // https://html.spec.whatwg.org/#handler-ondrag
'ondragend' => true, // https://html.spec.whatwg.org/#handler-ondragend
'ondragenter' => true, // https://html.spec.whatwg.org/#handler-ondragenter
'ondragleave' => true, // https://html.spec.whatwg.org/#handler-ondragleave
'ondragover' => true, // https://html.spec.whatwg.org/#handler-ondragover
'ondragstart' => true, // https://html.spec.whatwg.org/#handler-ondragstart
'ondrop' => true, // https://html.spec.whatwg.org/#handler-ondrop
'ondurationchange' => true, // https://html.spec.whatwg.org/#handler-ondurationchange
'onemptied' => true, // https://html.spec.whatwg.org/#handler-onemptied
'onended' => true, // https://html.spec.whatwg.org/#handler-onended
'onerror' => true, // https://html.spec.whatwg.org/#handler-onerror
'onfocus' => true, // https://html.spec.whatwg.org/#handler-onfocus
'oninput' => true, // https://html.spec.whatwg.org/#handler-oninput
'oninvalid' => true, // https://html.spec.whatwg.org/#handler-oninvalid
'onkeydown' => true, // https://html.spec.whatwg.org/#handler-onkeydown
'onkeypress' => true, // https://html.spec.whatwg.org/#handler-onkeypress
'onkeyup' => true, // https://html.spec.whatwg.org/#handler-onkeyup
'onload' => true, // https://html.spec.whatwg.org/#handler-onload
'onloadeddata' => true, // https://html.spec.whatwg.org/#handler-onloadeddata
'onloadedmetadata' => true, // https://html.spec.whatwg.org/#handler-onloadedmetadata
'onloadstart' => true, // https://html.spec.whatwg.org/#handler-onloadstart
'onmousedown' => true, // https://html.spec.whatwg.org/#handler-onmousedown
'onmousemove' => true, // https://html.spec.whatwg.org/#handler-onmousemove
'onmouseout' => true, // https://html.spec.whatwg.org/#handler-onmouseout
'onmouseover' => true, // https://html.spec.whatwg.org/#handler-onmouseover
'onmouseup' => true, // https://html.spec.whatwg.org/#handler-onmouseup
'onmousewheel' => true, // https://html.spec.whatwg.org/#handler-onmousewheel
'onpause' => true, // https://html.spec.whatwg.org/#handler-onpause
'onplay' => true, // https://html.spec.whatwg.org/#handler-onplay
'onplaying' => true, // https://html.spec.whatwg.org/#handler-onplaying
'onprogress' => true, // https://html.spec.whatwg.org/#handler-onprogress
'onratechange' => true, // https://html.spec.whatwg.org/#handler-onratechange
'onreadystatechange' => true, // https://html.spec.whatwg.org/#handler-onreadystatechange
'onreset' => true, // https://html.spec.whatwg.org/#handler-onreset
'onscroll' => true, // https://html.spec.whatwg.org/#handler-onscroll
'onseeked' => true, // https://html.spec.whatwg.org/#handler-onseeked
'onseeking' => true, // https://html.spec.whatwg.org/#handler-onseeking
'onselect' => true, // https://html.spec.whatwg.org/#handler-onselect
'onshow' => true, // https://html.spec.whatwg.org/#handler-onshow
'onstalled' => true, // https://html.spec.whatwg.org/#handler-onstalled
'onsubmit' => true, // https://html.spec.whatwg.org/#handler-onsubmit
'onsuspend' => true, // https://html.spec.whatwg.org/#handler-onsuspend
'ontimeupdate' => true, // https://html.spec.whatwg.org/#handler-ontimeupdate
'onvolumechange' => true, // https://html.spec.whatwg.org/#handler-onvolumechange
'onwaiting' => true, // https://html.spec.whatwg.org/#handler-onwaiting
'role' => true, // https://html.spec.whatwg.org/#attr-aria-role
'slot' => true, // https://html.spec.whatwg.org/#attr-slot
'spellcheck' => true, // https://html.spec.whatwg.org/#attr-spellcheck
'style' => true, // https://html.spec.whatwg.org/#attr-style
'tabindex' => true, // https://html.spec.whatwg.org/#attr-tabindex
'title' => true, // https://html.spec.whatwg.org/#attr-title
//'translate' => true, // https://html.spec.whatwg.org/#attr-translate
'xml:base' => true, // https://www.w3.org/TR/xmlbase/#syntax
'xml:lang' => true, // https://html.spec.whatwg.org/#the-lang-and-xml:lang-attributes
'xml:space' => true, // https://www.w3.org/TR/xml/#sec-white-space
];

/**
Expand All @@ -174,8 +183,8 @@ abstract class AbstractHelper extends BaseAbstractHelper
* @var array
*/
protected $validTagAttributePrefixes = [
'data-',
'aria-',
'data-', // https://html.spec.whatwg.org/#attr-data-*
'aria-', // https://html.spec.whatwg.org/#attr-aria-*
'x-',
];

Expand Down