This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Drop laminas/laminas-zendframework-bridge and zendframework/* compatibility
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerKiKi
force-pushed
the
drop-bridge
branch
from
1206771 to
7ade6ca
Compare
…patibility Increase performance by removing a compatibility layer while **not** introducing breaking changes. This follow the process described in details in: https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2021-08-02-TSC-Minutes.md#remove-laminaslaminas-zendframework-bridge-dependency-from-our-packages Signed-off-by: Adrien Crivelli <[email protected]>
PowerKiKi
force-pushed
the
drop-bridge
branch
from
7ade6ca to
e722f1e
Compare
Ocramius
suggested changes
Dec 6, 2021
Signed-off-by: Adrien Crivelli <[email protected]>
|
Tests should be fixed now |
Ocramius
reviewed
Dec 8, 2021
| TestAsset\WithMethodsNamedAfterKeywords\WithoutReturnTypeDeclaration::class, | ||
| TestAsset\WithMethodsNamedAfterKeywords\WithReturnTypeDeclaration::class, |
There was a problem hiding this comment.
It's a bit of a BC break, but 🤷 - no interface change.
|
Thanks @PowerKiKi! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase performance by removing a compatibility layer while not introducing breaking changes.
This follow the process described in details in:
https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2021-08-02-TSC-Minutes.md#remove-laminaslaminas-zendframework-bridge-dependency-from-our-packages