Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide php 8.1 support #40

Merged
merged 8 commits into from
Oct 31, 2021
Merged

Conversation

samsonasik
Copy link
Member

Q A
QA yes

Description

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik
Copy link
Member Author

There is error:

PHP Fatal error:  During inheritance of Countable: Uncaught Return type of Laminas\View\Model\ViewModel::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

EEE.

Fatal error: During inheritance of Countable: Uncaught Return type of Laminas\View\Model\ViewModel::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

it seems we need to have laminas-view support php 8.1 first ?

@froschdesign
Copy link
Member

Related to laminas/laminas-view#79

@froschdesign froschdesign added this to the 2.2.0 milestone Oct 4, 2021
@froschdesign
Copy link
Member

@samsonasik
Version 2.13.0 of laminas-view with PHP 8.1 support is released.

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik
Copy link
Member Author

@froschdesign updated, what correct command to generate composer.lock? I used composer update --prefer-lowest, is that correct?

@samsonasik
Copy link
Member Author

as it require laminas-servicemanager, and laminas-servicemanager that support php 8.1 use php 7.4 as requirement, it needs php 7.4 as requirement as well.

@samsonasik
Copy link
Member Author

I tweaked with exclude PHPUnit on PHP 8.1 with lowest dependencies in .laminas-ci.json

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik
Copy link
Member Author

it seems laminas-coding-standard needs to be updated :

Running ./vendor/bin/phpcs -q --report=checkstyle | cs2pr
249
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /github/workspace/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php on line 1763
250
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /github/workspace/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php on line 2846
251
Error: Start tag expected, '<' not found on line 2, column 

@froschdesign
Copy link
Member

@samsonasik

it seems laminas-coding-standard needs to be updated

This package still use version 1 of laminas-coding-standard:

"laminas/laminas-coding-standard": "~1.0.0",

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik
Copy link
Member Author

@froschdesign I regenerated composer.lock from php 7.3, All green 🎉

@samsonasik samsonasik changed the title Provide php 81 support Provide php 8.1 support Oct 31, 2021
@samsonasik
Copy link
Member Author

I am merging it ;)

@samsonasik samsonasik merged commit cb8da43 into laminas:2.2.x Oct 31, 2021
@samsonasik samsonasik deleted the provide-php81 branch October 31, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants