-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide php 8.1 support #40
Conversation
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
There is error: PHP Fatal error: During inheritance of Countable: Uncaught Return type of Laminas\View\Model\ViewModel::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
EEE.
Fatal error: During inheritance of Countable: Uncaught Return type of Laminas\View\Model\ViewModel::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice it seems we need to have |
Related to laminas/laminas-view#79 |
@samsonasik |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@froschdesign updated, what correct command to generate composer.lock? I used |
as it require laminas-servicemanager, and laminas-servicemanager that support php 8.1 use php 7.4 as requirement, it needs php 7.4 as requirement as well. |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
I tweaked with exclude PHPUnit on PHP 8.1 with lowest dependencies in |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
it seems laminas-coding-standard needs to be updated : Running ./vendor/bin/phpcs -q --report=checkstyle | cs2pr
249
PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /github/workspace/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php on line 1763
250
PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /github/workspace/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php on line 2846
251
Error: Start tag expected, '<' not found on line 2, column |
This package still use version 1 of laminas-coding-standard: laminas-developer-tools/composer.json Line 39 in be61c31
|
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@froschdesign I regenerated composer.lock from php 7.3, All green 🎉 |
I am merging it ;) |
Description