Removed phpdbg, added pcov dependency as part of the build
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a potential breaking change, but note that PHPUnit v10 no longer supports PHPDBG for coverage, which was the only use-case for PHPDBG in this container, thus far. We instead install `pcov`, which is considered precise enough for coverage reports by PHPUnit. Fixes laminas#130 Ref: laminas#130 Ref: sebastianbergmann/php-code-coverage#945 Ref: sebastianbergmann/php-code-coverage@c304be7
Ocramius
added
BC Break
Enhancement
dependencies
Ocramius
added a commit
to Ocramius/laminas-ci-matrix-action
that referenced
this pull request
Feb 22, 2023
Nnnnngh... gonna revert for those two... |
…alent APT package for those
1 task
|
I'm guessing we can't use PHPUnit 10 on those PHP versions anyway. |
internalsystemerror
approved these changes
Feb 22, 2023
|
I'm in favour of 1.33.0 FWIW - It's just a change in dependencies rather than an alteration to behaviour. The action will still do all of the things it was supposed to, in effectively the same way right? |
gsteel
approved these changes
Feb 22, 2023
If you were depending on phpdbg before, you won't be able to now. |
|
This will go to |
Ocramius
added a commit
to Ocramius/laminas-ci-matrix-action
that referenced
this pull request
Mar 2, 2023
|
Since @lcobucci is starting to get blocked by this quite a bit, I'm trying to push it forward :-) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential breaking change, but note that PHPUnit v10 no longer supports PHPDBG for coverage, which was the only use-case for PHPDBG in this container, thus far.
We instead install
pcov, which is considered precise enough for coverage reports by PHPUnit.Fixes #130
Ref: #130
Ref: sebastianbergmann/php-code-coverage#945
Ref: sebastianbergmann/php-code-coverage@c304be7
Only question here is:
1.33.0?2.0.0?