Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-output deprecation changed how multilines are handled #166

Conversation

internalsystemerror
Copy link
Member

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Several tags were being created that were invalid e.g. v1%0A1.21.0. It seems that when set-output was deprecated, github changed how multiline strings were handled. This PR should fix that issue according to: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings

@internalsystemerror
Copy link
Member Author

Rebased using #164 to allow CI to pass

Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in slack; changes look good. 🚢

@internalsystemerror internalsystemerror added this to the 1.22.0 milestone Dec 19, 2022
@internalsystemerror internalsystemerror merged commit 8f0274d into laminas:1.22.x Dec 19, 2022
@internalsystemerror internalsystemerror deleted the fix-tags-needing-multiline branch December 19, 2022 15:36
@Ocramius Ocramius added the Bug Something isn't working label Dec 19, 2022
@Ocramius
Copy link
Member

Nasty one: good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants