Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use PHP 8.1 syntax #345

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

samsonasik
Copy link
Member

Q A
QA yes

Description

Since composer.json require php 8.1, php 8.1 syntax can be applied.

@samsonasik samsonasik added this to the 4.1.0 milestone Nov 3, 2024
@samsonasik
Copy link
Member Author

Ready for review 👍 Test failure is unrelated, as I tested equal result in 4.1.x

➜  laminas-cache git:(4.1.x) vendor/bin/phpunit test/Psr/CacheItemPool/CacheItemTest.php
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.

......F...F                                                       11 / 11 (100%)

Time: 00:00.012, Memory: 6.00 MB

There were 2 failures:

1) LaminasTest\Cache\Psr\CacheItemPool\CacheItemTest::testExpiresAfterInt
Failed asserting that 7200 matches expected 3600.

/Users/samsonasik/www/laminas/laminas-cache/test/Psr/CacheItemPool/CacheItemTest.php:89

2) LaminasTest\Cache\Psr\CacheItemPool\CacheItemTest::testClockProvidedDoesNotContainUTCTimeZone
Failed asserting that 7200 matches expected 3600.

/Users/samsonasik/www/laminas/laminas-cache/test/Psr/CacheItemPool/CacheItemTest.php:147

@gsteel
Copy link
Member

gsteel commented Nov 25, 2024

Can you try a rebase here please @samsonasik ?

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik samsonasik force-pushed the update-to-use-php81-syntax branch from 2524cfb to 0347417 Compare November 26, 2024 00:42
@samsonasik
Copy link
Member Author

@gsteel rebased 👍

@samsonasik samsonasik requested a review from gsteel November 26, 2024 00:42
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samsonasik 👍

@gsteel gsteel self-assigned this Nov 26, 2024
@gsteel gsteel merged commit 2396d3f into laminas:4.1.x Nov 26, 2024
18 checks passed
@samsonasik samsonasik deleted the update-to-use-php81-syntax branch November 26, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants