CacheItemPoolDecorator does not properly handle multiple unsaved deferred items #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Fixes laminas#193 Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
bugfix/cache-item-pool-array-unique
branch
from
6edff92 to
f64ea2f
Compare
Signed-off-by: Maximilian Bösing <[email protected]>
Ocramius
approved these changes
Mar 24, 2022
|
Leaving merge+release up to you, since this is your turf :) |
|
Thanks for the review, @Ocramius! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #193