Revert changes made for adapter name from StoragePluginFactoryInterface and apply to StorageAdapterFactoryInterface instead
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Witold Wasiczko <[email protected]>
|
Then the other change should be reversed, right? |
|
Yes |
|
However then we will introduce new compatibility break... |
|
Please target 3.1.1, revert my commit from yesterday and keep these changes.
These changes were live for less than 24h. Even packagist states 0 installs for 3.1.0 (but its averaged on a weekly basis) so I think we might be fine. |
boesing
changed the title
adapter name from StoragePluginFactoryInterface and apply to StorageAdapterFactoryInterface instead
…ragePluginFactoryInterface`" This reverts commit 823776a. Signed-off-by: Witold Wasiczko <[email protected]>
boesing
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like fix #182 introduced by @boesing is wrong. This change should be applied to Adapters, not plugins. That's why doctrine/DoctrineModule#753 (comment) still fails.