move psalm validation error suppression for the RedisCluster construc…

…tor to the code Signed-off-by: robin-brabants <[email protected]> Co-authored-by: robin-brabants <[email protected]> Signed-off-by: Maximilian Bösing <[email protected]>
laminas · Apr 10, 2024 · da3bd31 · da3bd31
1 parent a195a52
commit da3bd31
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/psalm.xml b/psalm.xml
@@ -50,15 +50,6 @@
                 <directory name="*"/>
             </errorLevel>
         </RedundantCastGivenDocblockType>
-        <!--
-            Psalm currently (<= 5.23.1) uses an outdated (phpredis < 5.3.2) constructor signature for the RedisCluster
-            class in the phpredis extension.
-        -->
-        <TooManyArguments>
-            <errorLevel type="suppress">
-                <referencedFunction name="RedisCluster::__construct"/>
-            </errorLevel>
-        </TooManyArguments>
     </issueHandlers>
     <plugins>
         <pluginClass class="Psalm\PhpUnitPlugin\Plugin"/>

diff --git a/src/RedisClusterResourceManager.php b/src/RedisClusterResourceManager.php
@@ -91,6 +91,12 @@ private function createRedisResource(RedisClusterOptions $options): RedisCluster
             $password = null;
         }
 
+        /**
+         * Psalm currently (<= 5.23.1) uses an outdated (phpredis < 5.3.2) constructor signature for the RedisCluster
+         * class in the phpredis extension.
+         *
+         * @psalm-suppress TooManyArguments https://github.com/vimeo/psalm/pull/10862
+         */
         return new RedisClusterFromExtension(
             null,
             $options->getSeeds(),
@@ -119,6 +125,12 @@ private function createRedisResourceFromName(
         $readTimeout = $options->getReadTimeout($name, $fallbackReadTimeout);
         $password    = $options->getPasswordByName($name, $fallbackPassword);
 
+        /**
+         * Psalm currently (<= 5.23.1) uses an outdated (phpredis < 5.3.2) constructor signature for the RedisCluster
+         * class in the phpredis extension.
+         *
+         * @psalm-suppress TooManyArguments https://github.com/vimeo/psalm/pull/10862
+         */
         return new RedisClusterFromExtension(
             null,
             $seeds,