Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Psalm integration #43

Merged
merged 2 commits into from
Feb 9, 2022
Merged

feat: add Psalm integration #43

merged 2 commits into from
Feb 9, 2022

Conversation

superrosko
Copy link
Contributor

Q A
QA yes

Description

  • Create a psalm.xml.dist in the project root
  • Copy and paste the contents from this psalm.xml.dist and fix projectFiles
  • Run $ composer --dev require vimeo/psalm
  • Run $ composer require --dev psalm/plugin-phpunit
  • Run $ vendor/bin/psalm --config=psalm.xml.dist --set-baseline=psalm-baseline.xml
  • Add a composer script static-analysis with the command psalm --shepherd --stats
  • Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Closes #25

@superrosko superrosko force-pushed the feature/psalm-integration branch from a21441c to 4891743 Compare October 2, 2021 15:21
Ocramius
Ocramius requested changes Oct 2, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@superrosko superrosko force-pushed the feature/psalm-integration branch 2 times, most recently from 647f661 to 3f02d2a Compare October 2, 2021 15:31
@superrosko
feat: add Psalm integration
e726a51 
Signed-off-by: Dmitriy Bespalov <[email protected]>
@superrosko superrosko force-pushed the feature/psalm-integration branch from 3f02d2a to e726a51 Compare October 2, 2021 16:00
@superrosko superrosko requested a review from Ocramius October 2, 2021 16:00
@Ocramius Ocramius added this to the 1.7.0 milestone Feb 9, 2022
@Ocramius Ocramius self-assigned this Feb 9, 2022
@Ocramius Ocramius added the Enhancement New feature or request label Feb 9, 2022
Ocramius
Ocramius approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally missed this, thanks @superrosko!

@Ocramius Ocramius merged commit 1c2b680 into laminas-api-tools:1.7.x Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement New feature or request
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Psalm integration
2 participants
@superrosko @Ocramius