Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub actions workflow #29

Merged
merged 6 commits into from
Mar 13, 2021
Merged

GitHub actions workflow #29

merged 6 commits into from
Mar 13, 2021

Conversation

boesing
Copy link
Member

@boesing boesing commented Mar 13, 2021

Q A
QA yes

Description

Adding new github actions workflow.

@boesing boesing added the Enhancement New feature or request label Mar 13, 2021
@boesing boesing force-pushed the feature/github-actions-workflow branch 2 times, most recently from 84092e5 to 5ad2d17 Compare March 13, 2021 12:20
@boesing boesing changed the base branch from 1.5.x to 1.6.x March 13, 2021 12:30
@boesing boesing force-pushed the feature/github-actions-workflow branch from 4b7541e to 6128dae Compare March 13, 2021 12:30
@boesing
Copy link
Member Author

boesing commented Mar 13, 2021 •
edited
Loading

Thats interesting
@weierophinney it seems like somehow the matrix detects codestyle has to run but there are no such dependencies required in this package. thus, the codestyle checks fail.
I think I have to remove cs-check and cs-fix from composer.json to make it pass.

https://github.com/laminas-api-tools/api-tools-skeleton/pull/29/checks?check_run_id=2102225630

EDIT Well, the phpcs.xml was available but the project was lacking the dev requirement. I've added it and now anything passes.

@boesing boesing added this to the 1.6.0 milestone Mar 13, 2021
@boesing boesing merged commit 4353c6f into laminas-api-tools:1.6.x Mar 13, 2021
@boesing boesing deleted the feature/github-actions-workflow branch March 13, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@boesing