Fix module configuration to ensure services are mapped correctly #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Input filters, in particular, were mapped such that the POST/PATCH input filters were invalid - Legacy Apigility classes were mapped in such a way that Laminas service names might never match. The solution for this is to always list Apigility classes in quotations, and ensure that any `::class` notation is reserved for real classes and/or Laminas pseudo-classes. Fixes laminas-api-tools#71 Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Resolves new Psalm errors by referring to all pseudo-classes (only input filters at this point) via strings instead of `::class` notation. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
This was referenced Jan 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution for this is to always list Apigility classes in quotations, and ensure that any
::classnotation is reserved for real classes and/or Laminas pseudo-classes.Fixes #71