(api): Support creating index #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmarjanovic
requested changes
Nov 29, 2022
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
drmarjanovic
requested changes
Nov 29, 2022
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
| @@ -47,6 +47,11 @@ object ElasticRequest { | |||
| ): ElasticRequest[Unit] = | |||
| CreateOrUpdate(index, id, Document.from(doc), routing) | |||
|
|
|||
| def createIndex( | |||
| name: IndexName, | |||
| jsonBody: Option[String] | |||
There was a problem hiding this comment.
Not sure about this one...
I would definitely rename it to definition. @arnoldlacko
Also, should we use Json or String? 🤔
There was a problem hiding this comment.
Or maybe settings/configuration?
drmarjanovic
requested changes
Nov 29, 2022
| request | ||
| .put(uri"$basePath/${createIndex.name}") | ||
| .contentType(ApplicationJson) | ||
| .body(createIndex.jsonBody.getOrElse("")) |
There was a problem hiding this comment.
Is this the same behavior as creating it without body at all?
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala
Outdated
Show resolved
Hide resolved
markaya
force-pushed
the
executor-add-create-index
branch
from
63d5724 to
2a501c1
Compare
drmarjanovic
force-pushed
the
executor-add-create-index
branch
from
49d5b31 to
2520e00
Compare
drmarjanovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.