Support boost in Range and Bool query #88
Conversation
| @@ -16,8 +16,17 @@ | |||
|
|
|||
| package zio.elasticsearch | |||
|
|
|||
| import zio.elasticsearch.ElasticQuery.{ElasticPrimitive, MatchAllQuery, TermQuery, WildcardQuery} | |||
| import zio.elasticsearch.ElasticQueryType.{MatchAll, Term, Wildcard} | |||
| import zio.elasticsearch.ElasticQuery.{ | |||
There was a problem hiding this comment.
I guess we can import zio.elasticsearch.ElasticQuery._ instead.
| @@ -181,11 +182,12 @@ object ElasticQuery { | |||
| override def toJson: Option[(String, Json)] = None | |||
| } | |||
|
|
|||
| private[elasticsearch] final case class RangeQuery[A, LB <: LowerBound, UB <: UpperBound] private ( | |||
There was a problem hiding this comment.
Currently, we are working on some code improvements - take a look here.
Therefore, after that is applied we should be able to keep private here.
| @@ -62,6 +62,11 @@ object QueryDSLSpec extends ZIOSpecDefault { | |||
|
|
|||
| assert(query)(equalTo(MatchQuery(field = "name.keyword", value = "Name"))) | |||
| }, | |||
| test("successfully create Bool Query with boost") { | |||
| val query = boolQuery().boost(1.0) | |||
There was a problem hiding this comment.
After new changes are applied, we are going to use boolQuery. instead of boolQuery()..
| import zio.elasticsearch.ElasticQuery.{ | ||
| BoolQuery, | ||
| ElasticPrimitive, | ||
| LowerBound, | ||
| MatchAllQuery, | ||
| RangeQuery, | ||
| TermQuery, | ||
| UpperBound, | ||
| WildcardQuery | ||
| } |
There was a problem hiding this comment.
Can you import zio.elasticsearch.ElasticQuery._?
| @@ -181,11 +182,12 @@ object ElasticQuery { | |||
| override def toJson: Option[(String, Json)] = None | |||
| } | |||
|
|
|||
| private[elasticsearch] final case class RangeQuery[A, LB <: LowerBound, UB <: UpperBound] private ( | |||
| private[elasticsearch] final case class RangeQuery[A, LB <: LowerBound, UB <: UpperBound]( | |||
There was a problem hiding this comment.
Why did you omit private?
There was a problem hiding this comment.
I removed private because of boost default argument would raise a warning: private default argument in object RangeQuery is never used during during compilation on scala 2.12.17.
I saw that you removed all default arguments on case class, I'll make the changes !
kevchuang
force-pushed
the
support-boost-in-range-and-bool-queries
branch
from
c531a22 to
bed428e
Compare
kevchuang
force-pushed
the
support-boost-in-range-and-bool-queries
branch
2 times, most recently
from
5f38b7a to
b551983
Compare
kevchuang
force-pushed
the
support-boost-in-range-and-bool-queries
branch
from
b551983 to
0ca53f5
Compare
This PR addresses #66.