Use module pattern (remove execute method on requests) #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mijicd
reviewed
Feb 10, 2023
| @@ -45,14 +45,14 @@ object Main extends ZIOAppDefault { | |||
| val deleteIndex: RIO[ElasticExecutor, Unit] = | |||
| for { | |||
| _ <- ZIO.logInfo(s"Deleting index '$Index'...") | |||
| _ <- ElasticRequest.deleteIndex(Index).execute | |||
| _ <- ZIO.serviceWithZIO[ElasticExecutor](_.execute(ElasticRequest.deleteIndex(Index))) | |||
There was a problem hiding this comment.
This one is not bad, though it might need to adjust types to make it fully type-safe and maximize ergonomics.
mvelimir
force-pushed
the
module-pattern-2.0-1
branch
from
9098283 to
e21e5b6
Compare
modules/library/src/it/scala/zio/elasticsearch/IntegrationSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/Elasticsearch.scala
Outdated
Show resolved
Hide resolved
drmarjanovic
previously approved these changes
Feb 22, 2023
arnoldlacko
reviewed
Feb 22, 2023
|
|
||
| def findById(organization: String, id: String): Task[Option[GitHubRepo]] = | ||
| for { | ||
| routing <- routingOf(organization) | ||
| req = ElasticRequest.getById[GitHubRepo](Index, DocumentId(id)).routing(routing) | ||
| res <- executor.execute(req) | ||
| res <- elasticsearch.execute(req) |
There was a problem hiding this comment.
Could we inline the requests?
arnoldlacko
reviewed
Feb 22, 2023
| @@ -30,51 +30,53 @@ object HttpExecutorSpec extends IntegrationSpec { | |||
| test("successfully create document") { | |||
| checkOnce(genCustomer) { customer => | |||
| for { | |||
| docId <- ElasticRequest.create[CustomerDocument](index, customer).execute | |||
| res <- ElasticRequest.getById[CustomerDocument](index, docId).execute | |||
| docId <- Elasticsearch.execute(ElasticRequest.create[CustomerDocument](index, customer)) | |||
There was a problem hiding this comment.
Since this is the spec for the Executor itself, I would use it directly here.
arnoldlacko
reviewed
Feb 22, 2023
| @@ -66,7 +66,9 @@ object HttpElasticExecutorSpec extends WireMockSpec { | |||
| ) | |||
| ) | |||
|
|
|||
| assertZIO(addStubMapping *> ElasticRequest.bulk(ElasticRequest.create(index, repo)).refreshTrue.execute)( | |||
| assertZIO( | |||
| addStubMapping *> Elasticsearch.execute(ElasticRequest.bulk(ElasticRequest.create(index, repo)).refreshTrue) | |||
There was a problem hiding this comment.
I would rely directly on the layer that is being tested by the spec.
drmarjanovic
previously approved these changes
Feb 22, 2023
dbulaja98
previously approved these changes
Feb 23, 2023
mvelimir
dismissed stale reviews from dbulaja98 and drmarjanovic
via
c107f17
mvelimir
force-pushed
the
module-pattern-2.0-1
branch
from
db2abbb to
c107f17
Compare
drmarjanovic
changed the title
arnoldlacko
approved these changes
Feb 23, 2023
drmarjanovic
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.