(dsl): Support Weight Avg aggregation
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Nov 9, 2023
|
|
||
| If you want to add aggregation (on the same level), you can use `withAgg` method: | ||
| ```scala | ||
| val multipleAggregations: MultipleAggregations = weightedAvgAggregation(name = "weightedAvgAggregation", valueField = Document.intField, weightField = Document.doubleField).withAgg(weightedAvgAggregation(name = "weightedAvgAggregation", valueField = Document.doubleField, weightField = Document.intField)) |
There was a problem hiding this comment.
Can you give them different names?
|
|
||
| If you want to change the `valueMissing`, you can use `valueMissing` method: | ||
| ```scala | ||
| val aggregationWithMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).valueMissing(10.0) |
There was a problem hiding this comment.
Suggested change
| val aggregationWithMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).valueMissing(10.0) | |
| val aggregationWithValueMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).valueMissing(10.0) |
|
|
||
| If you want to change the `weightMissing`, you can use `weightMissing` method: | ||
| ```scala | ||
| val aggregationWithMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).weightMissing(5.0) |
There was a problem hiding this comment.
Suggested change
| val aggregationWithMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).weightMissing(5.0) | |
| val aggregationWithWeightMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).weightMissing(5.0) |
|
|
||
| If you want to change the `weightMissing` and `valueMissing`, you can use `weightMissing` and `valueMissing` methods: | ||
| ```scala | ||
| val aggregationWithMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).weightMissing(10.0).valueMissing(5.0) |
There was a problem hiding this comment.
Suggested change
| val aggregationWithMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).weightMissing(10.0).valueMissing(5.0) | |
| val aggregationWithValueAndWeightMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).weightMissing(10.0).valueMissing(5.0) |
| * @param valueField | ||
| * the type-safe field for value for which weighted avg aggregation will be executed | ||
| * @param weightField | ||
| * the type-safe field for weight for which weighted avg aggregation will be executed |
There was a problem hiding this comment.
Maybe something like this:
Suggested change
| * the type-safe field for weight for which weighted avg aggregation will be executed | |
| * the type-safe field that represents weight for which weighted avg aggregation will be executed |
There was a problem hiding this comment.
Something like this for valueField also.
| self.copy(weightMissing = Some(value)) | ||
|
|
||
| private[elasticsearch] def toJson: Json = { | ||
|
|
| ))) | ||
| ) | ||
| ) | ||
|
|
Comment on lines
95
to
96
| case str if str.contains("weighted_avg#") => | ||
| WeightedAvgAggregationResponse.decoder.decodeJson(data.toString).map(field.split("#")(1) -> _) |
There was a problem hiding this comment.
Put this first and remove && !str.contains("weighted_avg#") from the first case.
| weightedAvgAggregation("aggregation", TestDocument.stringField, TestDocument.intField).valueMissing(2.0) | ||
| val aggregationWithWeightMissing = | ||
| weightedAvgAggregation("aggregation", TestDocument.stringField, TestDocument.intField).weightMissing(3.0) | ||
| val aggregationWithBothMissing = weightedAvgAggregation( |
There was a problem hiding this comment.
Suggested change
| val aggregationWithBothMissing = weightedAvgAggregation( | |
| val aggregationWithValueAndWeightMissing = weightedAvgAggregation( |
| weightedAvgAggregation("aggregation", TestDocument.stringField, TestDocument.intField).valueMissing(2.0) | ||
| val aggregationWithWeightMissing = | ||
| weightedAvgAggregation("aggregation", TestDocument.stringField, TestDocument.intField).weightMissing(3.0) | ||
| val aggregationWithBothMissing = weightedAvgAggregation( |
vanjaftn
force-pushed
the
task-support-weighted-avg-aggregation
branch
2 times, most recently
from
384cbac to
4237565
Compare
vanjaftn
changed the title
Weight Avg aggregation
dbulaja98
requested changes
Nov 12, 2023
|
|
||
| If you want to add aggregation (on the same level), you can use `withAgg` method: | ||
| ```scala | ||
| val multipleAggregations: MultipleAggregations = weightedAvgAggregation(name = "weightedAvgAggregation", valueField = Document.intField, weightField = Document.doubleField).withAgg(weightedAvgAggregation(name = "weightedAvgAggregation2", valueField = Document.doubleField, weightField = Document.intField)) |
There was a problem hiding this comment.
Suggested change
| val multipleAggregations: MultipleAggregations = weightedAvgAggregation(name = "weightedAvgAggregation", valueField = Document.intField, weightField = Document.doubleField).withAgg(weightedAvgAggregation(name = "weightedAvgAggregation2", valueField = Document.doubleField, weightField = Document.intField)) | |
| val multipleAggregations: MultipleAggregations = weightedAvgAggregation(name = "weightedAvgAggregation1", valueField = Document.intField, weightField = Document.doubleField).withAgg(weightedAvgAggregation(name = "weightedAvgAggregation2", valueField = Document.doubleField, weightField = Document.intField)) |
|
|
||
| If you want to change the `weightMissing` and `valueMissing`, you can use `weightMissing` and `valueMissing` methods: | ||
| ```scala | ||
| val aggregationWithValueAndWeightMissing: WeightedAvgAggregation = weightedAvgAggregation(name = "weightedAvgAggregation", field = Document.intField).weightMissing(10.0).valueMissing(5.0) |
There was a problem hiding this comment.
Put valueMissing first.
vanjaftn
force-pushed
the
task-support-weighted-avg-aggregation
branch
from
8c2d3d2 to
c76e95f
Compare
dbulaja98
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #118